gh-125259: Fix error notes removal in enum initialization #125647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfurman
approved these changes
Oct 22, 2024
ethanfurman
added
type-bug
|
Thanks @mariosasko for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @mariosasko and @ethanfurman, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 22, 2024
…onGH-125647) (cherry picked from commit 34653bb) Co-authored-by: Mario Šaško <[email protected]>
|
GH-125858 is a backport of this pull request to the 3.13 branch. |
ethanfurman
pushed a commit
that referenced
this pull request
Oct 25, 2024
ethanfurman
pushed a commit
to ethanfurman/cpython
that referenced
this pull request
Oct 25, 2024
…onGH-125647) (cherry picked from commit 34653bb)
|
GH-125953 is a backport of this pull request to the 3.12 branch. |
ethanfurman
added a commit
that referenced
this pull request
Oct 25, 2024
…125647) (GH-125953) (cherry picked from commit 34653bb) Co-authored-by: Mario Šaško <[email protected]>
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the notes of errors thrown in enum class initialization instead of re-instantiating them (without notes), which might not always be possible.
TypeErrorwhen raising an exception inside the__init__method of an enum class #125259